Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed precision check in TestCase.run_layer_test: compare with output_spec dtype instead of hardcoded float16 #19297

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Fix mixed precision check in TestCase.run_layer_test: compare with output_spec dtype instead of hardcoded float16 #19297

merged 7 commits into from
Mar 14, 2024

Conversation

shkarupa-alex
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (c8700f4) to head (8ecb5c5).
Report is 95 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19297      +/-   ##
==========================================
- Coverage   80.14%   75.56%   -4.59%     
==========================================
  Files         341      365      +24     
  Lines       36163    39863    +3700     
  Branches     7116     7747     +631     
==========================================
+ Hits        28982    30121    +1139     
- Misses       5578     8062    +2484     
- Partials     1603     1680      +77
Flag Coverage Δ
keras 75.41% <90.00%> (-4.58%) ⬇️
keras-jax 59.65% <90.00%> (-3.41%) ⬇️
keras-numpy 54.19% <0.00%> (-2.89%) ⬇️
keras-tensorflow 61.15% <90.00%> (-3.50%) ⬇️
keras-torch 60.26% <90.00%> (-3.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shkarupa-alex
Copy link
Contributor Author

Need help with Tests / Check the code format (pull_request) Failing after 1m.
File is formatted as described in contribution docs.

> sh shell/format.sh
Skipped 26 files
All done! ✨ 🍰 ✨
626 files left unchanged.

@gbaned gbaned requested a review from fchollet March 13, 2024 08:34
@fchollet
Copy link
Member

Tests / Check the code format (pull_request)

Run sh shell/format.sh to format the code.

@shkarupa-alex
Copy link
Contributor Author

Tests / Check the code format (pull_request)

Run sh shell/format.sh to format the code.

As i wrote here #19297 (comment) i already ran that script.

@fchollet
Copy link
Member

would reformat /home/runner/work/keras/keras/keras/testing/test_case.py

I suppose you don't have the latest version of black installed?

@shkarupa-alex
Copy link
Contributor Author

would reformat /home/runner/work/keras/keras/keras/testing/test_case.py

I suppose you don't have the latest version of black installed?

Updated to latest version 24.2.0 (previous version installed with requirements.txt as noted in contribution docs).
Now reformatting replaced from keras import ... to from keras.src import ...

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Mar 14, 2024
@fchollet fchollet merged commit c591329 into keras-team:master Mar 14, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
size:XS
Projects
PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shkarupa-alex @codecov-commenter @fchollet @gbaned